Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[b33eff]: CSS to put text on screen when rotated #2109

Merged
merged 9 commits into from
Dec 14, 2023
Merged

[b33eff]: CSS to put text on screen when rotated #2109

merged 9 commits into from
Dec 14, 2023

Conversation

tombrunet
Copy link
Collaborator

@tombrunet tombrunet commented Aug 31, 2023

Adjusts the CSS so that the content is "visible" to avoid voiding the applicability of the rule.

Closes issue(s):

Need for Call for Review:

This will require a 1 week Call for Review


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@tombrunet tombrunet added the Rule Update Use this label for an existing rule that is being updated label Aug 31, 2023
@tombrunet tombrunet self-assigned this Aug 31, 2023
@tombrunet tombrunet requested a review from WilcoFiers August 31, 2023 19:54
Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, although I also seem to have issues with failed example 1 and 4. We should probably solve those as well.

Copy link
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked all the other examples, but this is improving the situation on these two.

@tombrunet
Copy link
Collaborator Author

@WilcoFiers Fixed fail 1 and fail 4.

@tombrunet tombrunet requested a review from WilcoFiers October 26, 2023 13:04
@tombrunet tombrunet dismissed WilcoFiers’s stale review November 3, 2023 17:29

Requested changes applied

@tombrunet tombrunet changed the title CSS to put text on screen when rotated [b33eff]: CSS to put text on screen when rotated Nov 30, 2023
Copy link
Member

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jym77 Jym77 added Review Call 1 week Call for review for small changes and removed reviewers wanted labels Dec 7, 2023
@Jym77
Copy link
Collaborator

Jym77 commented Dec 7, 2023

Call for Review ends on December 14th.

@Jym77
Copy link
Collaborator

Jym77 commented Dec 14, 2023

Cal for Review has ended. Merging.

@Jym77 Jym77 merged commit 7612976 into develop Dec 14, 2023
2 checks passed
@Jym77 Jym77 deleted the issue-1782 branch December 14, 2023 10:07
@AndyAtTV
Copy link

AndyAtTV commented Mar 8, 2024

Inapplicable Example 3 appears to have two mistakes: landscape is misspelled as lanscape, and rotateZ() should only have 1 argument, not 4 (maybe it should be rotate3d ?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Call 1 week Call for review for small changes Rule Update Use this label for an existing rule that is being updated
Projects
None yet
6 participants