-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[b33eff]: CSS to put text on screen when rotated #2109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, although I also seem to have issues with failed example 1 and 4. We should probably solve those as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked all the other examples, but this is improving the situation on these two.
@WilcoFiers Fixed fail 1 and fail 4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Call for Review ends on December 14th. |
Cal for Review has ended. Merging. |
Inapplicable Example 3 appears to have two mistakes: landscape is misspelled as lanscape, and rotateZ() should only have 1 argument, not 4 (maybe it should be rotate3d ?) |
Adjusts the CSS so that the content is "visible" to avoid voiding the applicability of the rule.
Closes issue(s):
Need for Call for Review:
This will require a 1 week Call for Review
Pull Request Etiquette
When creating PR:
develop
branch (left side).After creating PR:
Rule
,Definition
orChore
.When merging a PR:
How to Review And Approve